Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis tests for this project #174

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jwg4
Copy link

@jwg4 jwg4 commented Aug 21, 2017

(in progress)

jwg4 added 3 commits August 21, 2017 09:36
This corresponds to the actual current behavior and the behavior of redis-py. The intended behavior might be the opposite, however it makes sense to change the test since
1. Clearly no-one depends on the intended behavior - the tests have not passed for 3 years.
2. Some people might depend on the actual behavior.
3. It seems silly to go out of our way to make this work differently to redis-py.

See https://github.com/andymccurdy/redis-py/blob/8a186ebd9cecf466624803bdf215030158c7c776/redis/connection.py#L810
@dengshaochun dengshaochun mentioned this pull request Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant